Edward Chung

Developer Pro

Activity

Mon

Wed

Fri

Sun

Aug

Sep

Oct

Nov

Dec

Jan

Feb

Mar

Apr

May

Jun

What is this?

Less

Memberships

Developer Pro

Public • 116 • Free

14 contributions to Developer Pro

Edward Chung

Feb 23

Code Review

Crypto App Review

Here's the updated link to our app, @Cristian Florea. Please review and let us know any issues https://nexa-coin.vercel.app/

New comment Feb 26

Edward Chung

0 likes • Feb 26

@Cristian Florea For the 3 charts, you need to click compare first to be able to select up to 3. You shouldn't be able to select more than 1 when not in compare mode. I'll make another PR for the other changes you mentioned

Edward Chung

Feb 23

Code Review

Crypto App PR 18 - Issues Fixed

Hey @Cristian Florea , my brother and I fixed the issues you pointed out in the last PR. Please review. https://github.com/edchrepo/nexa-coin/pull/18 -Carousel functionality fixed (selected coins are locked in place) -Effects added for charts (crosshairs + hover)

New comment Feb 23

Ellis Chung

Feb 19

Code Review

Crypto App PR 17 - Extra feature completed

Hey @Cristian Florea, I looked over the uniswap app you showed me and we added skeleton loading effect for the coins & charts, forgot that was one last requirement we needed to do. Lmk what you think https://github.com/edchrepo/nexa-coin/pull/17

New comment Feb 20

Edward Chung

1 like • Feb 19

For anyone who wants to check out our finished app: https://nexa-coin.vercel.app/

Edward Chung

1 like • Feb 19

@Cristian Florea yea the copy clipboard feedback, cursor pointers, and carousel selection feedback were all included in this recent PR, it just wasn’t deployed yet on vercel since the PR had to be approved first. We’ll work on the other things mentioned though.

Edward Chung

Feb 9

Code Review

PR Crypto App Responsiveness

Added responsiveness for crypto app, please review @Cristian Florea https://github.com/edchrepo/nexa-coin/pull/16

New comment Feb 12